AsperforMias opened a new pull request, #1638:
URL: https://github.com/apache/dubbo-admin/pull/1638

   **Please provide a description of this PR:**
   
   Discovery informers list resources for one mesh, but use a resource store 
shared across meshes. During a list replacement, an informer can therefore 
treat another mesh's resources as deleted. For example, a Nacos refresh can 
remove ZooKeeper service metadata from the Admin catalog even though the 
ZooKeeper nodes still exist.
   
   Scope each discovery informer's known-object view to its mesh. Both ListKeys 
and GetByKey use exact mesh identity, while stale-resource deletion and watch 
updates/deletions within the same mesh remain unchanged. The change stays 
within discovery and does not modify the shared controller.
   
   Tests cover both cross-mesh ordering directions, mesh names containing 
slashes, stale-resource deletion, watch updates/deletions, and relisting. The 
regression fails on the original implementation and passes with this change. 
Targeted tests, race tests, vet, and lint for the changed package pass.
   
   Real Nacos/ZooKeeper checks passed after two independent Admin restarts 
using this patch. Service lists, details, methods, and non-IDL invocation 
remained available.
   
   The adapter scans the existing per-kind List view. It does not change the 
store's existing list-error handling contract.
   
   **To help us figure out who should review this PR, please put an X in all 
the areas that this PR affects.**
   
   - [ ] Docs
   - [ ] Installation
   - [ ] User Experience
   - [ ] Dubboctl
   - [ ] Console
   - [X] Core Component
   
   
   **Please check any characteristics that apply to this pull request.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to