AsperforMias opened a new pull request, #1642: URL: https://github.com/apache/dubbo-admin/pull/1642
**Please provide a description of this PR:** Update the instance dashboard handler test to match the existing IP-label contract. The service, Grafana dashboards, and documentation use the instance IP as var-instance. The handler test still expects IP:QoSPort for metrics, causing the unit-test workflow to fail on develop. Adding that port back to production would not match the dashboards' ip label queries. Assert the bare instance IP for metric, trace, and log dashboards. Cover IPv4 and IPv6 with both configured and missing QoS ports. Production behavior is unchanged. Validation: - The original handler test fails before this change and passes afterward. - make test and go vet ./... pass. - Targeted race tests and lint for new changes pass. This does not change metrics scraping or resolve the separate exporter-port issue. **To help us figure out who should review this PR, please put an X in all the areas that this PR affects.** - [ ] Docs - [ ] Installation - [ ] User Experience - [ ] Dubboctl - [X] Console - [ ] Core Component **Please check any characteristics that apply to this pull request.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
