Alanxtl commented on PR #3830: URL: https://github.com/apache/dubbo-go/pull/3830#issuecomment-6935547369
The latest commit removes `TestListener` from `RACE_SKIP_TESTS`, although the PR description notes that running it after other Apollo tests can expose an Agollo race. I reproduced that failure with: ```bash go test -race -count=1 ./config_center/apollo ``` The race detector reports `getAppConfig` racing with `SyncAndUpdate` in an Agollo client started by `TestGetJsonConfig`, and attributes the failure to `TestListener`. This failed on both Windows and Linux; the focused listener tests passed, as did the package race run with `TestListener` skipped. The current CI run passed, but the race is timing-dependent, so enabling the test can make `make test-race` flaky. The race should be isolated or fixed before removing the skip. The PR also currently has a **Makefile merge conflict** with `develop`, where #3827 removed a neighboring skip-list entry. Reviewed commit: `299d3a2`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
