chaoyoung commented on code in PR #16583:
URL: https://github.com/apache/dubbo/pull/16583#discussion_r4598417774


##########
dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/command/HttpWriteQueue.java:
##########
@@ -42,6 +49,10 @@ protected void prepare(HttpChannelQueueCommand item) {
     @Override
     protected void flush(HttpChannelQueueCommand item) {
         item.run();
-        item.getHttpChannel().flush();
+        if (batchFlush != null) {
+            batchFlush.run();

Review Comment:
   Added the invariant comment in ba5b733236 at the batchFlush branch: the 
queue-owning channel must be flushed because the final command can target a 
closed HTTP/2 stream and strand sibling writes. This follow-up changes comments 
only. Before pushing, the full http12 package ran 41 tests with zero 
failures/errors and the two existing Linux-only XML tests skipped on macOS; 
formatting and whitespace checks passed. The legacy constructor remains 
unchanged on 3.3. HTTP/3 semantics are separate follow-up scope.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to