AsperforMias opened a new pull request, #3834:
URL: https://github.com/apache/dubbo-go/pull/3834

   ### Description
   
   Related to https://github.com/apache/dubbo-go/issues/3595; this does not 
close the issue.
   
   Preserve an invocation's timeout attachment instead of overwriting it with 
the URL timeout. When applying a default timeout to a unary call without a 
context deadline, accept a positive unitless millisecond value as well as an 
existing Go duration string.
   
   Keep existing context deadlines, configuration fallbacks, and timeout header 
encoding unchanged. This does not change AttachmentKey, GetParamDuration, 
streaming timeout behavior, or enable timeout countdown by default.
   
   Tests cover call-level precedence, duration and millisecond values, invalid 
values, configuration fallback, and existing deadlines. A Go-to-Go test 
exercises the production Triple invocation and h2c handler paths, observing the 
handler context and grpc-timeout header. The two affected cases fail on the 
unmodified baseline; the new end-to-end test passed five runs with the race 
detector. Java interoperability was not tested.
   
   Validation includes the affected package tests, targeted race tests, vet, 
formatting, and scoped lint from the local validation rounds. The final added 
cases passed targeted race tests and vet on Go 1.26.1; the CI Go 1.25.0 
toolchain and module-wide Make targets have not been rerun locally.
   
   ### Checklist
   - [x] I confirm the target branch is `develop`
   - [ ] I have run `make fmt` to format my code
   - [ ] I have run `make test` to run local tests
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to