AsperforMias commented on code in PR #3832:
URL: https://github.com/apache/dubbo-go/pull/3832#discussion_r4601585319


##########
remoting/getty/getty_client.go:
##########
@@ -267,6 +267,11 @@ func (c *Client) RequestContext(ctx context.Context, 
request *remoting.Request,
        case <-response.Done:
                err = response.Err
        case <-ctx.Done():
+               // Drop the pending waiter, but keep the shared session. Caller
+               // cancellation is not a transport failure; a later request may
+               // reuse this connection. The read-timeout branch still closes
+               // the session because that path can no longer trust it.
+               
remoting.RemovePendingResponse(remoting.SequenceType(request.ID))

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to