shubhamk0205 commented on code in PR #403:
URL: https://github.com/apache/dubbo-go-hessian2/pull/403#discussion_r4639592736
##########
object_test.go:
##########
@@ -1069,6 +1069,22 @@ func TestDecodeIntegerHasNull(t *testing.T) {
testDecodeFramework(t, "customReplyTypedIntegerHasNull", &User{Id: nil})
}
+type DoubleHolder struct {
+ Value float64
+ PtrValue *float64
+}
+
+func (h *DoubleHolder) JavaClassName() string {
+ return "test.model.DoubleHolder"
+}
+
+// https://github.com/apache/dubbo-go-hessian2/issues/305
+func TestDecodeDoubleHasNull(t *testing.T) {
+ RegisterPOJO(&DoubleHolder{})
+
Review Comment:
Good point, added a name field like in the original report, so the test now
also checks the object was actually decoded.
thanks @AlexStocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]