We should use defensive programming to judge **names** is not either null or
empty, plus, I suggest we should loop **names** once and only once, see below:
```suggestion
String[] names = NAME_SEPARATOR.split(name);
if (ArrayUtils.isNotEmpty(names)) {
cacheActivateClass(clazz, names[0]);
for (String n : names) {
cacheName(clazz, n);
saveInExtensionClass(extensionClasses, clazz, name);
}
}
```
Let's loop outside, and change cacheNames to cacheName, and change
saveInExtensionClasses to saveInExtensionClass
[ Full content available at:
https://github.com/apache/incubator-dubbo/pull/3410 ]
This message was relayed via gitbox.apache.org for
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
