zouyx commented on a change in pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#discussion_r437107907
##########
File path: config_center/nacos/client.go
##########
@@ -50,6 +51,15 @@ type NacosClient struct {
onceClose func()
}
+func init() {
+ switch runtime.GOOS {
+ case "windows":
+ logDir = "logs\\nacos\\log"
+ default:
+ logDir = "logs/nacos/log"
+ }
+}
+
Review comment:
Inaddition to set default value for `logDir`, we should provide a config
item to change this value
##########
File path: config_center/nacos/client.go
##########
@@ -50,6 +51,15 @@ type NacosClient struct {
onceClose func()
}
+func init() {
+ switch runtime.GOOS {
+ case "windows":
+ logDir = "logs\\nacos\\log"
+ default:
+ logDir = "logs/nacos/log"
+ }
+}
+
Review comment:
In addition to set default value for `logDir`, we should provide a
config item to change this value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
