wenxuwan commented on a change in pull request #1010:
URL: https://github.com/apache/dubbo-go/pull/1010#discussion_r563057726
##########
File path: config_center/zookeeper/impl.go
##########
@@ -209,8 +205,6 @@ func (c *zookeeperDynamicConfiguration) closeConfigs() {
c.cltLock.Lock()
defer c.cltLock.Unlock()
logger.Infof("begin to close provider zk client")
- // Close the old client first to close the tmp node
- c.client.Close()
Review comment:
所有的registry公用一个zkClient, 不需要每个registry退出就close掉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]