beiwei30 commented on a change in pull request #68:
URL: https://github.com/apache/dubbo-go-samples/pull/68#discussion_r594028376
##########
File path: tls/go-client/app/client.go
##########
@@ -0,0 +1,84 @@
+package main
Review comment:
pls. add apache license header
##########
File path: tls/go-server/app/version.go
##########
@@ -0,0 +1,5 @@
+package main
Review comment:
remove it.
##########
File path: tls/go-server/app/user.go
##########
@@ -0,0 +1,47 @@
+package main
Review comment:
pls. add apache license header.
##########
File path: tls/go-server/app/server.go
##########
@@ -0,0 +1,80 @@
+package main
Review comment:
pls. add apache license header.
##########
File path: tls/go-client/app/env.sh
##########
@@ -0,0 +1,3 @@
+export CONF_CONSUMER_FILE_PATH=../profiles/dev/client.yml
Review comment:
avoid use shell script to start. try if build/makefile work or not. pls.
refer to HOWTO.md
##########
File path: tls/go-server/app/start.sh
##########
@@ -0,0 +1,4 @@
+export CONF_PROVIDER_FILE_PATH="../conf/server.yml"
Review comment:
avoid use shell script to start. try if build/makefile work or not. pls.
refer to HOWTO.md
##########
File path: tls/go-server/app/env.sh
##########
@@ -0,0 +1,2 @@
+export CONF_PROVIDER_FILE_PATH="../profiles/dev/server.yml"
Review comment:
avoid use shell script to start. try if build/makefile work or not. pls.
refer to HOWTO.md
##########
File path: tls/go-client/app/start.sh
##########
@@ -0,0 +1,3 @@
+export CONF_CONSUMER_FILE_PATH="../conf/client.yml"
Review comment:
avoid use shell script to start. try if build/makefile work or not. pls.
refer to HOWTO.md
##########
File path: tls/go-client/app/user.go
##########
@@ -0,0 +1,34 @@
+package main
Review comment:
pls. add apache license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
