AlbumenJ commented on pull request #8083: URL: https://github.com/apache/dubbo/pull/8083#issuecomment-864678668
> > I don't think it's a good modification, it import new dependency but not obvious optimization. > > I think the dependency package vavr is not only for this place, there are many other places that can be optimized by vavr. As a RPC framework, it is better that we should limit our dependencies and do not transfer dependencies to users which can cause dependency confilcts easily for users. It is clear that we can depend on those we really needed dependencies like `netty` we cannot take place it. But for code optimize, it might not a good choice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
