[GitHub] [dubbo] BurningCN commented on a change in pull request #8065: Fix the issue that the ReferenceConfigCache#destroy method does not call proxy.$destroy()

Sun, 20 Jun 2021 19:34:21 -0700 


BurningCN commented on a change in pull request #8065:
URL: https://github.com/apache/dubbo/pull/8065#discussion_r655037447



##########
File path: 
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/utils/ReferenceConfigCache.java
##########
@@ -175,7 +175,8 @@ public void destroy(String key, Class<?> type) {
 
         Map<String, Object> proxiesOftype = proxies.get(type);
         if (CollectionUtils.isNotEmptyMap(proxiesOftype)) {
-            proxiesOftype.remove(key);
+            Destroyable proxy = (Destroyable) proxiesOftype.remove(key);

Review comment:
       The generated proxy instances all automatically implement the 
Destroyable interface, right?
   
   
![image](https://user-images.githubusercontent.com/43363120/122699402-ee8d9a80-d27b-11eb-9d50-7bf726eb635f.png)
   
![image](https://user-images.githubusercontent.com/43363120/122699541-2c8abe80-d27c-11eb-9d38-dfe6eb6d9bd3.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to