AlbumenJ commented on a change in pull request #8186:
URL: https://github.com/apache/dubbo/pull/8186#discussion_r670365681
##########
File path:
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
##########
@@ -1103,26 +1108,25 @@ public DubboBootstrap start() {
}
referServices();
- if (asyncExportingFutures.size() > 0 ||
asyncReferringFutures.size() > 0) {
- new Thread(() -> {
+
+ // wait async export / refer finish if needed
+ awaitFinish();
+
+ new Thread(() -> {
Review comment:
Is it necessary to create a thread even if users not specify async
export?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
