guohao commented on a change in pull request #8584:
URL: https://github.com/apache/dubbo/pull/8584#discussion_r699150196
##########
File path:
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
##########
@@ -260,7 +270,7 @@ private void checkAndUpdateSubConfigs() {
// init some null configuration.
List<ConfigInitializer> configInitializers =
ExtensionLoader.getExtensionLoader(ConfigInitializer.class)
- .getActivateExtension(URL.valueOf("configInitializer://"),
(String[]) null);
+ .getActivateExtension(URL.valueOf("configInitializer://"),
(String[]) null);
Review comment:
Plz fix fomat
##########
File path:
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
##########
@@ -239,6 +239,16 @@ public synchronized void export() {
}
}
+ protected void doDelayExport() {
+ DELAY_EXPORT_EXECUTOR.schedule(() -> {
+ try {
+ doExport();
+ } catch (Exception e) {
+ logger.error(e);
Review comment:
Add some brief info such as `logger.error("Export service ${foo}
failed",e)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
