guohao commented on a change in pull request #8712:
URL: https://github.com/apache/dubbo/pull/8712#discussion_r704002087
##########
File path:
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/UnaryServerStream.java
##########
@@ -98,11 +101,11 @@ public void invoke() {
try {
if (response.hasException()) {
final Throwable exception = response.getException();
- if (exception instanceof TripleRpcException) {
- transportError(((TripleRpcException)
exception).getStatus(), response.getObjectAttachments());
+ if (exception instanceof RpcException) {
+
transportError(rpcExceptionCodeToGrpc(((RpcException) exception).getCode()),
response.getObjectAttachments());
Review comment:
detail msg in `RPCException` has been dropped, should be pass to
`Status`' description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
