changfubai commented on issue #8726:
URL: https://github.com/apache/dubbo/issues/8726#issuecomment-915879666


   这个是为了解决这个case: #7656
   
   把DUBBO_DUBBO_PORT_TO_BIND和DUBBO_PORT_TO_REGISTRY两个配置统一了。
   如果DUBBO_PORT_TO_REGISTRY指定了就用这个;没指定就用DUBBO_DUBBO_PORT_TO_BIND。
   
   ps:我觉得这个代码的写法确实不是很合适,如果是我会这么写:
   
   portToBind = portToRegistry == null ? portToRegistry : portToRegistry;  
   map.put(BIND_PORT_KEY, String.valueOf(portToBind));
   
   这样可读性会高一点;
   
   我后续调整一下。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to