tydhot commented on a change in pull request #236: URL: https://github.com/apache/dubbo-go-pixiu/pull/236#discussion_r705817766
########## File path: pkg/filter/tracing/tracing.go ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package tracing + +import ( + "context" + "log" + "net/http" +) + +import ( + "go.opentelemetry.io/otel" + "go.opentelemetry.io/otel/exporters/jaeger" + "go.opentelemetry.io/otel/sdk/resource" + tracesdk "go.opentelemetry.io/otel/sdk/trace" + semconv "go.opentelemetry.io/otel/semconv/v1.4.0" + "go.opentelemetry.io/otel/trace" +) + +import ( + "github.com/apache/dubbo-go-pixiu/pkg/common/constant" + "github.com/apache/dubbo-go-pixiu/pkg/common/extension/filter" + "github.com/apache/dubbo-go-pixiu/pkg/config" + contexthttp "github.com/apache/dubbo-go-pixiu/pkg/context/http" +) + +const ( + TracingType_Jaeger = "jaeger" + traceName = "http-server" + spanNamePrefix = "HTTP SERVER" + jaegerTraceIDInHeader = "uber-trace-id" +) + +// nolint +func init() { + filter.RegisterHttpFilter(&Plugin{}) +} + +// tracerFilter is a filter for tracer +type Plugin struct { +} + +type TraceFilter struct { +} + +func (ap *Plugin) Kind() string { + return constant.TracingFilter +} + +func (ap *Plugin) CreateFilter() (filter.HttpFilter, error) { + New() + return &TraceFilter{}, nil +} + +func (m *TraceFilter) Config() interface{} { + return nil +} + +func (m *TraceFilter) Apply() error { + // init + New() + return nil +} + +func (mf *TraceFilter) PrepareFilterChain(ctx *contexthttp.HttpContext) error { + ctx.AppendFilterFunc(mf.Handle) + return nil +} + +func newTracerProvider(url string) (*tracesdk.TracerProvider, error) { + // Create the Jaeger exporter + exp, err := jaeger.New(jaeger.WithCollectorEndpoint(jaeger.WithEndpoint(url))) + if err != nil { + return nil, err + } + tp := tracesdk.NewTracerProvider( + // Always be sure to batch in production. + tracesdk.WithBatcher(exp), + // Record information about this application in an Resource. + tracesdk.WithResource(resource.NewWithAttributes( + semconv.SchemaURL, + semconv.ServiceNameKey.String("pixiu"), + )), + ) + + return tp, nil +} + +// New create tracer filter. +func New() TraceFilter { + tc := config.GetBootstrap().Tracing + switch tc.Type { + case "": + return TraceFilter{} + case TracingType_Jaeger: + tp, err := newTracerProvider(tc.URL) + if err != nil { + log.Fatal(err) + } + otel.SetTracerProvider(tp) + default: + panic("unsupported tracing") + } + + return TraceFilter{} +} + +// Do execute tracerFilter filter logic. +func (f TraceFilter) Handle(hc *contexthttp.HttpContext) { + spanName := spanNamePrefix + hc.Request.Method + " " + hc.Request.URL.Path Review comment: 一般情况下在网关层spanName直接到method就可以了，不需要把url path作为spanName。这是一个会无限膨胀的字段，会给后期聚合带来非常大的困难。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
