MentosL commented on a change in pull request #8713:
URL: https://github.com/apache/dubbo/pull/8713#discussion_r706615391
##########
File path:
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
##########
@@ -1273,7 +1273,7 @@ private void waitExportFinish() {
try {
logger.info(NAME + " waiting services exporting
asynchronously...");
CompletableFuture<?> future =
CompletableFuture.allOf(asyncExportingFutures.toArray(new
CompletableFuture[0]));
- future.get();
+ future.get(3, TimeUnit.SECONDS);
Review comment:
The 3 seconds here is the total result of waiting. In fact, each export
is a separate future, which can be satisfied according to the maximum time of 3
seconds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
