AlexStocks commented on a change in pull request #1507:
URL: https://github.com/apache/dubbo-go/pull/1507#discussion_r725495304
##########
File path: config/reference_config.go
##########
@@ -176,25 +176,25 @@ func (rc *ReferenceConfig) Refer(srv interface{}) {
if len(invokers) == 1 {
rc.invoker = invokers[0]
if rc.URL != "" {
- hitClu := constant.FAILOVER_CLUSTER_NAME
+ hitClu := constant.ClusterKeyFailOver
if u := rc.invoker.GetURL(); u != nil {
- hitClu = u.GetParam(constant.CLUSTER_KEY,
constant.ZONEAWARE_CLUSTER_NAME)
+ hitClu = u.GetParam(constant.CLUSTER_KEY,
constant.ClusterKeyZoneAware)
}
- rc.invoker =
extension.GetCluster(hitClu).Join(directory.NewStaticDirectory(invokers))
+ rc.invoker =
extension.GetCluster(hitClu).Join(static.NewDirectory(invokers))
}
} else {
var hitClu string
if regURL != nil {
// for multi-subscription scenario, use 'zone-aware'
policy by default
- hitClu = constant.ZONEAWARE_CLUSTER_NAME
+ hitClu = constant.ClusterKeyZoneAware
} else {
// not a registry url, must be direct invoke.
- hitClu = constant.FAILOVER_CLUSTER_NAME
+ hitClu = constant.ClusterKeyFailOver
Review comment:
failover 是一个整体的 word，不要搞个 FailOver 出来。你看看其他地方有没有这样写，都改下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
