kylixs commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r734296978
##########
File path:
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java
##########
@@ -625,18 +634,27 @@ public void prepareApplicationInstance() {
}
}
+ /**
+ * start and await internal module deploy finished if internal module
deployer is not running.
+ */
+ @SuppressWarnings("rawtypes")
private void prepareInternalModule() {
// export MetadataService
exportMetadataService();
// start internal module
ModuleDeployer internalModuleDeployer =
applicationModel.getInternalModule().getDeployer();
- if (!internalModuleDeployer.isStarted()) {
- Future future = internalModuleDeployer.start();
- // wait for internal module start finished
+ if (internalModuleDeployer.isRunning()) {
+ return;
Review comment:
We MUST ensure to start internal module first, that will make start
steps more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
