HildoYe opened a new pull request #9123: URL: https://github.com/apache/dubbo/pull/9123
## What is the purpose of the change The test `org.apache.dubbo.common.utils.AnnotationUtilsTest#testGetAllDeclaredAnnotations` is flaky. If run with different random seeds it will fail occasionally. The root cause of it is due to an ordering bug in `java.lang.reflect` package. The function `getDeclaredAnnotation` does not have persistent order when calling each time. This fix is mainly to mute the acknowledge the existence of the ordering issue and mute the bug in test case. ## Brief changelog Rewrite the testcase in a different manner. The new testcase is not assuming a fixed order of `annotations`. Instead it dynamically tries to match the types. The previous test fails here because the wrong order of `annotations` may lead to an impossible conversion. ## Verifying this change `mvn -pl dubbo-common edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=org.apache.dubbo.common.utils.AnnotationUtilsTest#testGetAllDeclaredAnnotations` `mvn -pl dubbo-common edu.illinois:nondex-maven-plugin:1.1.2:nondex -DnondexRuns=NUMBER -Dtest=org.apache.dubbo.common.utils.AnnotationUtilsTest#testGetAllDeclaredAnnotations` <!-- Follow this checklist to help us incorporate your contribution quickly and easily: --> ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
