BurningCN commented on a change in pull request #9273:
URL: https://github.com/apache/dubbo/pull/9273#discussion_r748863791
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/DefaultExecutorRepository.java
##########
@@ -352,7 +354,11 @@ public ScheduledExecutorService
getSharedScheduledExecutor() {
}
private ExecutorService createExecutor(URL url) {
- return (ExecutorService)
extensionAccessor.getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url);
+ ExecutorService executorService = (ExecutorService)
ExtensionLoader.getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url);
+
+ DataStore dataStore =
ExtensionLoader.getExtensionLoader(DataStore.class).getDefaultExtension();
+ dataStore.put(EXECUTOR_SERVICE_COMPONENT_KEY,
Integer.toString(url.getPort()), executorService);
Review comment:
In the `destroyAll` method, the DataSource should be cleaned up
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/DefaultExecutorRepository.java
##########
@@ -352,7 +354,11 @@ public ScheduledExecutorService
getSharedScheduledExecutor() {
}
private ExecutorService createExecutor(URL url) {
- return (ExecutorService)
extensionAccessor.getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url);
+ ExecutorService executorService = (ExecutorService)
ExtensionLoader.getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url);
Review comment:
The original code should be used here
`ExecutorService executorService = (ExecutorService)
extensionAccessor.getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
