pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749892275
##########
File path:
dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/ZookeeperRegistryCenter.java
##########
@@ -87,10 +98,47 @@ public ZookeeperRegistryCenter() {
*/
private Map<OS, Map<Command, Processor>> processors = new HashMap<>();
+ /**
+ * The default unpacked directory.
+ */
+ private static final String UNPACKED_DIRECTORY = "apache-zookeeper-bin";
+
+ /**
+ * The target name of zookeeper binary file.
+ */
+ private static final String TARGET_ZOOKEEPER_FILE_NAME =
UNPACKED_DIRECTORY + ".tar.gz";
+
+ /**
+ * The target directory.
+ * The zookeeper binary file named {@link #TARGET_ZOOKEEPER_FILE_NAME}
will be saved in
+ * {@link #TARGET_DIRECTORY} if it downloaded successfully.
+ */
+ private static final String TARGET_DIRECTORY = "test" + File.separator +
"zookeeper";
Review comment:
> It is better to change the directory name similar to `.test`, `.tmp`.
The `test` directory can be used for meaningful things.
OK, I have renamed the directory's name from test to .tmp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
