Mulavar commented on a change in pull request #1604:
URL: https://github.com/apache/dubbo-go/pull/1604#discussion_r761764166
##########
File path: config/method_config.go
##########
@@ -70,9 +76,34 @@ func initProviderMethodConfig(sc *ServiceConfig) error {
}
// check set default value and verify
-func (mc *MethodConfig) check() error {
- if err := defaults.Set(mc); err != nil {
+func (m *MethodConfig) check() error {
+ qualifieldMethodName := m.InterfaceName + "#" + m.Name
+ if m.TpsLimitStrategy != "" {
+ _ = extension.GetTpsLimitStrategyCreator(m.TpsLimitStrategy)
Review comment:
call this to check if we enable the corresponding strategy, maybe adding
one more function is a better way to detect this, I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
