AlbumenJ commented on a change in pull request #9348:
URL: https://github.com/apache/dubbo/pull/9348#discussion_r762711558
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/config/CompositeConfiguration.java
##########
@@ -21,19 +21,20 @@
import org.apache.dubbo.common.utils.ArrayUtils;
import java.util.Arrays;
+import java.util.Collections;
import java.util.LinkedList;
import java.util.List;
/**
* This is an abstraction specially customized for the sequence Dubbo
retrieves properties.
*/
public class CompositeConfiguration implements Configuration {
- private Logger logger =
LoggerFactory.getLogger(CompositeConfiguration.class);
+ private final Logger logger =
LoggerFactory.getLogger(CompositeConfiguration.class);
/**
* List holding all the configuration
*/
- private List<Configuration> configList = new LinkedList<>();
+ private final List<Configuration> configList =
Collections.synchronizedList(new LinkedList<>());
Review comment:
Use CopyOnWriteArrayList may be better. `synchronizedList` will block
some read operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
