Mulavar commented on a change in pull request #1675:
URL: https://github.com/apache/dubbo-go/pull/1675#discussion_r785444491
##########
File path: config/graceful_shutdown.go
##########
@@ -53,36 +53,48 @@ import (
*/
const defaultShutDownTime = time.Second * 60
-// GracefulShutdownInit todo GracefulShutdownInit in 3.0 should be discusesed.
-func GracefulShutdownInit() {
- signals := make(chan os.Signal, 1)
-
- signal.Notify(signals, ShutdownSignals...)
-
+func gracefulShutdownInit() {
// retrieve ShutdownConfig for gracefulShutdownFilter
- if filter, ok :=
extension.GetFilter(constant.GracefulShutdownConsumerFilterKey).(Setter); ok &&
rootConfig.Shutdown != nil {
- filter.Set(constant.GracefulShutdownFilterShutdownConfig,
rootConfig.Shutdown)
+ cGracefulShutdownFilter, existcGracefulShutdownFilter :=
extension.GetFilter(constant.GracefulShutdownConsumerFilterKey)
+ if !existcGracefulShutdownFilter {
+ return
+ }
+ sGracefulShutdownFilter, existsGracefulShutdownFilter :=
extension.GetFilter(constant.GracefulShutdownProviderFilterKey)
Review comment:
对应 cGracefulShutdownFilter 的缩写，这里的命名应该是 pGracefulShutdownFilter？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
