AlbumenJ commented on a change in pull request #9187:
URL: https://github.com/apache/dubbo/pull/9187#discussion_r790245440
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/extension/Inject.java
##########
@@ -22,8 +22,20 @@
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
+import static org.apache.dubbo.common.extension.Inject.InjectType.ByName;
+
@Documented
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.TYPE, ElementType.METHOD})
-public @interface DisableInject {
+public @interface Inject {
+ // whether enable injection or not
+ boolean enable() default true;
+
+ // inject type default by name injection
+ InjectType type() default ByName;
+
+ enum InjectType{
+ ByName,
+ ByType
+ }
Review comment:
I am worried about this change may break some implementation work fine
before commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
