BurningCN commented on a change in pull request #9732:
URL: https://github.com/apache/dubbo/pull/9732#discussion_r818274600
##########
File path:
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh/route/MeshRuleRouter.java
##########
@@ -108,7 +108,8 @@ public MeshRuleRouter(URL url) {
}
}
}
- result = result.or(ruleCache.getUnmatchedInvokers());
Review comment:
My understanding here is: Assuming the above operation makes the
`result` non-empty (with a matching invoker), if the `UnmatchedInvoker` is
non-empty, this line of code will cause the unmatched ones to be merged into
the result, so I think this line of code should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
