sconvent commented on PR #11260: URL: https://github.com/apache/dubbo/pull/11260#issuecomment-1377914218
@AlbumenJ It is best practice to have the `.mvn/wrapper/maven-wrapper.jar` checked in into the repo of the project. And it was updated using the recommended way (as stated in the PR with `mvn wrapper:wrapper -Dmaven=3.8.7)`. That command alone did the updates in this PR. I believe sticking to the recommended setup is a good way unless there are good reasons against it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org