songxiaosheng commented on code in PR #11317:
URL: https://github.com/apache/dubbo/pull/11317#discussion_r1071730255
##########
dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/MetricThreadPool.java:
##########
@@ -0,0 +1,25 @@
+package org.apache.dubbo.common.threadpool;
Review Comment:
add apache license
##########
dubbo-common/src/main/java/org/apache/dubbo/common/metrics/model/ThreadPoolMetric.java:
##########
@@ -0,0 +1,101 @@
+package org.apache.dubbo.common.metrics.model;
Review Comment:
add apache license
##########
dubbo-common/src/main/java/org/apache/dubbo/common/metrics/model/MetricsKey.java:
##########
@@ -42,6 +42,13 @@ public enum MetricsKey {
PROVIDER_METRIC_RT_P99("dubbo.provider.rt.p99", "Response Time P99"),
PROVIDER_METRIC_RT_P95("dubbo.provider.rt.p95", "Response Time P95"),
+ THREAD_POOL_CORE_SIZE("thread.pool.core.size","thread pool core size"),
Review Comment:
指标命名规范后面需要改一下 改为，dubbo.线程池类型 开头
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
