[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

[GitBox]

conghuhu commented on code in PR #11021:
URL: https://github.com/apache/dubbo/pull/11021#discussion_r1071941307


##########
dubbo-metrics/dubbo-metrics-api/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.cluster.filter.ClusterFilter:
##########
@@ -0,0 +1,2 @@
+observationreceiver=org.apache.dubbo.metrics.filter.observation.ObservationReceiverFilter
+observationsender=org.apache.dubbo.metrics.filter.observation.ObservationSenderFilter

Review Comment:
   I found some problems with the location of the resources folder:
   
![image](https://user-images.githubusercontent.com/56248584/212855602-526e733b-52de-400c-8e44-9de90025b956.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org