AlbumenJ commented on code in PR #11493:
URL: https://github.com/apache/dubbo/pull/11493#discussion_r1105223362
##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/MetricsKey.java:
##########
@@ -54,8 +54,32 @@ public enum MetricsKey {
THREAD_POOL_ACTIVE_SIZE("dubbo.thread.pool.active.size","Thread Pool
Active Size"),
THREAD_POOL_THREAD_COUNT("dubbo.thread.pool.thread.count","Thread Pool
Thread Count"),
THREAD_POOL_QUEUE_SIZE("dubbo.thread.pool.queue.size","Thread Pool Queue
Size"),
+ // register metrics key
+ REGISTER_METRIC_REQUESTS("dubbo.registry.register.requests.total", "Total
Register Requests"),
+
REGISTER_METRIC_REQUESTS_SUCCEED("dubbo.registry.register.requests.succeed.total",
"Succeed Register Requests"),
+
REGISTER_METRIC_REQUESTS_FAILED("dubbo.registry.register.requests.failed.total",
"Failed Register Requests"),
+
+ // subscribe metrics key
+ SUBSCRIBE_METRIC_REQUESTS("dubbo.registry.subscribe.requests.total",
"Total Subscribe Requests"),
+
SUBSCRIBE_METRIC_REQUESTS_SUCCEED("dubbo.registry.subscribe.requests.succeed.total",
"Succeed Subscribe Requests"),
+
SUBSCRIBE_METRIC_REQUESTS_FAILED("dubbo.registry.subscribe.requests.failed.total",
"Failed Subscribe Requests"),
+
+ // directory metrics key
+ DIRECTORY_METRIC_NUM("dubbo.registry.directory.num.total", "Total
directory urls"),
+ DIRECTORY_METRIC_NUM_VALID("dubbo.registry.directory.num.valid.total",
"Valid directory urls"),
+
DIRECTORY_METRIC_NUM_UN_VALID("dubbo.registry.directory.num.un_valid.total",
"UnValid directory urls"),
Review Comment:
Collect total, valid, invokersToReconnect, disabledInvokers count
##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/MetricsKey.java:
##########
@@ -54,8 +54,32 @@ public enum MetricsKey {
THREAD_POOL_ACTIVE_SIZE("dubbo.thread.pool.active.size","Thread Pool
Active Size"),
THREAD_POOL_THREAD_COUNT("dubbo.thread.pool.thread.count","Thread Pool
Thread Count"),
THREAD_POOL_QUEUE_SIZE("dubbo.thread.pool.queue.size","Thread Pool Queue
Size"),
+ // register metrics key
+ REGISTER_METRIC_REQUESTS("dubbo.registry.register.requests.total", "Total
Register Requests"),
+
REGISTER_METRIC_REQUESTS_SUCCEED("dubbo.registry.register.requests.succeed.total",
"Succeed Register Requests"),
+
REGISTER_METRIC_REQUESTS_FAILED("dubbo.registry.register.requests.failed.total",
"Failed Register Requests"),
+
+ // subscribe metrics key
+ SUBSCRIBE_METRIC_REQUESTS("dubbo.registry.subscribe.requests.total",
"Total Subscribe Requests"),
+
SUBSCRIBE_METRIC_REQUESTS_SUCCEED("dubbo.registry.subscribe.requests.succeed.total",
"Succeed Subscribe Requests"),
+
SUBSCRIBE_METRIC_REQUESTS_FAILED("dubbo.registry.subscribe.requests.failed.total",
"Failed Subscribe Requests"),
Review Comment:
这里不是要记录什么时候订阅，而是记录在某个时间点下总共有多少个订阅数已经提交了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
