AlbumenJ commented on code in PR #11522:
URL: https://github.com/apache/dubbo/pull/11522#discussion_r1105300403
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java:
##########
@@ -357,13 +363,27 @@ private void initMetricsService() {
metricsServiceExporter.init();
}
+ @SuppressWarnings({"rawtypes"})
private void initMetricsReporter() {
- DefaultMetricsCollector collector =
-
applicationModel.getFrameworkModel().getBeanFactory().getOrRegisterBean(DefaultMetricsCollector.class);
+ ScopeBeanFactory beanFactory =
applicationModel.getFrameworkModel().getBeanFactory();
+ DefaultMetricsCollector collector =
beanFactory.getOrRegisterBean(DefaultMetricsCollector.class);
MetricsConfig metricsConfig = configManager.getMetrics().orElse(null);
+ this.eventMulticaster =
beanFactory.getOrRegisterBean(SimpleMetricsEventMulticaster.class);
+
// TODO compatible with old usage of metrics, remove protocol check
after new metrics is ready for use.
if (metricsConfig != null &&
PROTOCOL_PROMETHEUS.equals(metricsConfig.getProtocol())) {
collector.setCollectEnabled(true);
+
+ List<MetricsListener> metricsListeners =
applicationModel.getExtensionLoader(MetricsListener.class)
+ .getActivateExtensions();
+ metricsListeners.forEach(this.eventMulticaster::addListener);
+
+ List<MetricsCollector> customizeCollectors =
applicationModel.getExtensionLoader(MetricsCollector.class)
+ .getActivateExtensions();
+ for (MetricsCollector customizeCollector : customizeCollectors) {
+ beanFactory.registerBean(customizeCollector);
+ }
+
Review Comment:
https://github.com/apache/dubbo/pull/11493#pullrequestreview-1296730732
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java:
##########
@@ -772,4 +774,26 @@ public Invoker<?> getInvoker() {
public Runnable getDestroyRunner() {
return this::destroy;
}
+
+ @Override
+ @Parameter(excluded = true, attribute = false)
+ public int getInvokerNum() {
+ Invoker<?> invoker = getInvoker();
+ if (invoker instanceof MigrationInvoker) {
+ AbstractDirectory<?> directory = (AbstractDirectory<?>)
((MigrationInvoker<?>) invoker).getDirectory();
+ return directory.getAllInvokers().size();
+ }
+ return super.getInvokerNum();
+ }
+
+ @Override
+ @Parameter(excluded = true, attribute = false)
+ public int getValidInvokerNum() {
+ Invoker<?> invoker = getInvoker();
+ if (invoker instanceof MigrationInvoker) {
+ AbstractDirectory<?> directory = (AbstractDirectory<?>)
((MigrationInvoker<?>) invoker).getDirectory();
+ return directory.getValidInvokers().size();
+ }
+ return super.getValidInvokerNum();
+ }
Review Comment:
https://github.com/apache/dubbo/pull/11493#pullrequestreview-1296730732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
