chickenlj commented on code in PR #12450:
URL: https://github.com/apache/dubbo/pull/12450#discussion_r1220841899
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java:
##########
@@ -333,8 +337,18 @@ public <T> void reExport(Exporter<T> exporter, URL
newInvokerUrl) {
*/
@SuppressWarnings("unchecked")
public <T> void reExport(final Invoker<T> originInvoker, URL
newInvokerUrl) {
- String key = getCacheKey(originInvoker);
- ExporterChangeableWrapper<T> exporter = (ExporterChangeableWrapper<T>)
bounds.get(key);
+ String providerUrlKey = getProviderUrlKey(originInvoker);
+ String registryUrlKey = getRegistryUrlKey(originInvoker);
+ Map<String, ExporterChangeableWrapper<?>> registryMap =
bounds.get(providerUrlKey);
Review Comment:
What's the purpose of adding an extra `registryUrl` layer for exporters?
Is it because we need to do `reExport` for a single registry at one time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
