[GitHub] [dubbo] RapperCL opened a new issue, #12654: Metircs: I think the requestBeforeEvent in metrics may be redundant and needs to be optimized.

Mon, 03 Jul 2023 02:29:17 -0700 


RapperCL opened a new issue, #12654:
URL: https://github.com/apache/dubbo/issues/12654

   
   "RequestBeforeEvent" is a type of "RequestEvent" (which terminates 
execution) and should not be created as a new class as it is redundant and 
difficult to maintain. 
   If it is necessary to separately monitor this type of event,  it is 
recommended to add the constant "INVOCATION_REQUEST_BEFORE" and provide the 
"isRequestBeforeEvent" method.
   
   forexample: 
    add constant: 
   
![image](https://github.com/apache/dubbo/assets/44110731/a1e22fa1-c1e8-4894-9a1b-29cb1c918953)
   Add the toRequestBeforeEvent method：
   
![image](https://github.com/apache/dubbo/assets/44110731/1b21520e-afd1-4250-9b14-439481f30ae2)
   
   Add  the isRequestBeforeEvent method:
   
![image](https://github.com/apache/dubbo/assets/44110731/9494af6e-b6c9-4be9-ab21-cc8f4b8c6229)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to