AlbumenJ commented on code in PR #12582:
URL: https://github.com/apache/dubbo/pull/12582#discussion_r1264808712
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultModuleDeployer.java:
##########
@@ -428,7 +434,14 @@ private void exportServiceInternal(ServiceConfigBase sc) {
asyncExportingFutures.add(future);
} else {
if (!sc.isExported()) {
- sc.export(RegisterTypeEnum.AUTO_REGISTER_BY_DEPLOYER);
+ List<URL> registryURLs =
ConfigValidationUtils.loadRegistries(sc, true);
+ List<String> serviceDiscoveryNames =
registryURLs.stream().map(url->
url.getParameter(RegistryConstants.REGISTRY_CLUSTER_KEY)).distinct().collect(Collectors.toList());
Review Comment:
If `REGISTRY_CLUSTER` is empty, use `protocol` by default
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/metadata/ServiceInstanceMetadataUtils.java:
##########
@@ -201,7 +205,24 @@ public static void
registerMetadataAndInstance(ApplicationModel applicationModel
LOGGER.info("Start registering instance address to registry.");
RegistryManager registryManager =
applicationModel.getBeanFactory().getBean(RegistryManager.class);
// register service instance
-
registryManager.getServiceDiscoveries().forEach(ServiceDiscovery::register);
+ List<ServiceDiscovery> serviceDiscoveries =
registryManager.getServiceDiscoveries();
+ serviceDiscoveries.forEach(ServiceDiscovery::register);
+ if (serviceDiscoveries.size() > 0) {
+
MetricsEventBus.post(RegistryEvent.toRegisterEvent(applicationModel,
getServiceDiscoveryNames(serviceDiscoveries)),
+ () -> {
+ // register service instance
+ serviceDiscoveries.forEach(ServiceDiscovery::register);
+ return null;
+ }
+ );
+ }
+ }
+
+ private static List<String>
getServiceDiscoveryNames(List<ServiceDiscovery> serviceDiscoveries) {
+ return serviceDiscoveries
+ .stream()
+ .map(sd ->
sd.getUrl().getParameter(RegistryConstants.REGISTRY_CLUSTER_KEY))
Review Comment:
If `REGISTRY_CLUSTER` is empty, use `protocol` by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
