AlbumenJ commented on code in PR #12761:
URL: https://github.com/apache/dubbo/pull/12761#discussion_r1273529058
##########
dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosNamingServiceWrapper.java:
##########
@@ -278,7 +278,7 @@ public ListView<String> getServicesOfServer(int pageNo, int
pageSize, String gro
}
public List<Instance> selectInstances(String serviceName, String group,
boolean healthy) throws NacosException {
- return apply(() ->
nacosConnectionManager.getNamingService().selectInstances(handleInnerSymbol(serviceName),
group, healthy));
+ return apply(() ->
nacosConnectionManager.getNamingService().selectInstances(handleInnerSymbol(serviceName),
group, healthy, false));
Review Comment:
What is the purpose of change this? Dubbo will subscribe to that service
after select. So `subscribe` can reuse the reqeust in one RT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
