finefuture commented on code in PR #13024:
URL: https://github.com/apache/dubbo/pull/13024#discussion_r1322810889
##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConnectionHandler.java:
##########
@@ -61,10 +61,6 @@ public void onGoAway(Object channel) {
if (connectionClient != null) {
connectionClient.onGoaway(nettyChannel);
}
- if (LOGGER.isDebugEnabled()) {
- LOGGER.debug(String.format("Channel %s go away ,schedule
reconnect", nettyChannel));
- }
- reconnect(nettyChannel);
Review Comment:
GoAway Frame is used to handle server connection closure graceful, if client
don't know the change of service list, it should be complete with heartbeat
task, refer: #12955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
