chickenlj commented on code in PR #2454:
URL: https://github.com/apache/dubbo-go/pull/2454#discussion_r1385904656
##########
protocol/triple/client.go:
##########
@@ -143,14 +143,14 @@ func newClientManager(url *common.URL) (*clientManager,
error) {
panic(fmt.Sprintf("Unsupported serialization: %s",
serialization))
}
- // todo:// process timeout
- // consumer config client connectTimeout
- //connectTimeout := config.GetConsumerConfig().ConnectTimeout
+ // set timeout
+ timeout := url.GetParamDuration(constant.TimeoutKey, "")
Review Comment:
What's the default timeout value for `(constant.TimeoutKey, "")`?
##########
protocol/triple/client.go:
##########
@@ -143,14 +143,14 @@ func newClientManager(url *common.URL) (*clientManager,
error) {
panic(fmt.Sprintf("Unsupported serialization: %s",
serialization))
}
- // todo:// process timeout
- // consumer config client connectTimeout
- //connectTimeout := config.GetConsumerConfig().ConnectTimeout
+ // set timeout
+ timeout := url.GetParamDuration(constant.TimeoutKey, "")
Review Comment:
If I understand it right, this `url` contains the complete configuration of
a specific service? I think we need to call something like below to get the
method level timeout configuration:
`timeout := url.GetMethodParamDuration(constant.TimeoutKey, "")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
