DMwangnima commented on code in PR #2532:
URL: https://github.com/apache/dubbo-go/pull/2532#discussion_r1419203690
##########
protocol/triple/triple_protocol/handler.go:
##########
@@ -255,7 +341,11 @@ func (h *Handler) ServeHTTP(responseWriter
http.ResponseWriter, request *http.Re
return
}
// invoke implementation
- _ = connCloser.Close(h.implementation(ctx, connCloser))
+ svcGroup := request.Header.Get(tripleServiceGroup)
+ svcVersion := request.Header.Get(tripleServiceVersion)
+ implementation := h.implementations[getIdentifier(svcGroup, svcVersion)]
Review Comment:
I need to check the Triple protocol specification in Dubbo since this is not
an official feature in gRPC.
That is the reason why I left a todo here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
