yin1999 commented on PR #136: URL: https://github.com/apache/dubbo-kubernetes/pull/136#issuecomment-1876955031
Before merging this PR, please consider whether we should use the `go:embed` directive instead of the textual bytes array in go source file. Actually, as the bytes array has been compressed, it is difficult for us to read it directly. Storing it in text form does not bring any benefits and will increase the disk usage of the source code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
