AlbumenJ commented on code in PR #13904:
URL: https://github.com/apache/dubbo/pull/13904#discussion_r1534959792
##########
dubbo-remoting/dubbo-remoting-netty4/src/test/java/org/apache/dubbo/remoting/transport/netty4/ConnectionTest.java:
##########
@@ -138,6 +138,7 @@ void connectSyncTest() throws Throwable {
nettyPortUnificationServer.bind();
// auto reconnect
+ Thread.sleep(60000);
Review Comment:
Use awaitility to verify
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/AbstractClient.java:
##########
@@ -55,13 +63,23 @@ public abstract class AbstractClient extends
AbstractEndpoint implements Client
protected volatile ExecutorService executor;
+ protected volatile ScheduledExecutorService connectivityExecutor;
+
+ private ApplicationModel applicationModel;
+
+ protected long reconnectDuaration;
+
public AbstractClient(URL url, ChannelHandler handler) throws
RemotingException {
super(url, handler);
// set default needReconnect true when channel is not connected
needReconnect = url.getParameter(Constants.SEND_RECONNECT_KEY, true);
+ applicationModel = url.getOrDefaultApplicationModel();
Review Comment:
Directly get Framework Model here would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
