walklown commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1535259906
########## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ########## @@ -53,6 +53,13 @@ <dependencyManagement> <dependencies> + <dependency> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>31</version> + <type>pom</type> + <scope>import</scope> + </dependency> Review Comment: Some original poms use this parent pom to determine the version of plugins, while others specify the version directly. The dubbo project itself is specified through the parent pom, so this method is currently used. Actually I don't mind which one to use, but it is recommended to unify -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org