github-advanced-security[bot] commented on code in PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#discussion_r1542288357
########## tls/xds/xds_provider.go: ########## @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package xds + +import ( + "crypto/tls" + "crypto/x509" + "fmt" + "sync" + + "dubbo.apache.org/dubbo-go/v3/common" + "dubbo.apache.org/dubbo-go/v3/common/constant" + "dubbo.apache.org/dubbo-go/v3/common/extension" + "dubbo.apache.org/dubbo-go/v3/istio" + "dubbo.apache.org/dubbo-go/v3/istio/resources" + tlsprovider "dubbo.apache.org/dubbo-go/v3/tls" + "github.com/dubbogo/gost/log/logger" +) + +var ( + once sync.Once + tlsProvider *xdsTLSProvider +) + +func init() { + extension.SetTLSProvider(constant.TLSProviderXdsKey, newXdsTLSProvider) +} + +type xdsTLSProvider struct { + pilotAgent istio.XdsAgent +} + +func newXdsTLSProvider() tlsprovider.TLSProvider { + if tlsProvider == nil { + once.Do(func() { + logger.Infof("[xds tls] init pilot agent") + pilotAgent, err := istio.GetPilotAgent(istio.PilotAgentTypeServerWorkload) + if err != nil { + logger.Errorf("[xds tls] init pilot agent err:%", err) + } + tlsProvider = &xdsTLSProvider{ + pilotAgent: pilotAgent, + } + }) + } + return tlsProvider +} + +func (x *xdsTLSProvider) GetServerWorkLoadTLSConfig(url *common.URL) (*tls.Config, error) { + cfg := &tls.Config{ + GetCertificate: x.GetWorkloadCertificate, + ClientAuth: tls.VerifyClientCertIfGiven, // for test only + //ClientAuth: tls.RequireAndVerifyClientCert, // for prod + ClientCAs: x.GetCACertPool(), + VerifyPeerCertificate: func(rawCerts [][]byte, verifiedChains [][]*x509.Certificate) error { + err := x.VerifyPeerCertByServer(rawCerts, verifiedChains) + if err != nil { + logger.Errorf("Could not verify client certificate: %v", err) + } + return err + }, + MinVersion: tls.VersionTLS12, + CipherSuites: tlsprovider.PreferredDefaultCipherSuites(), + NextProtos: []string{"h2", "http/1.1"}, + PreferServerCipherSuites: true, + } + + return cfg, nil +} + +func (x *xdsTLSProvider) VerifyPeerCertByServer(rawCerts [][]byte, verifiedChains [][]*x509.Certificate) error { + logger.Infof("[xds tls] server verifiy peer cert") + if len(rawCerts) == 0 { + // Peer doesn't present a certificate. Just skip. Other authn methods may be used. + return nil + } + var peerCert *x509.Certificate + intCertPool := x509.NewCertPool() + for id, rawCert := range rawCerts { + cert, err := x509.ParseCertificate(rawCert) + if err != nil { + return err + } + if id == 0 { + peerCert = cert + } else { + intCertPool.AddCert(cert) + } + } + if len(peerCert.URIs) != 1 { + return fmt.Errorf("peer certificate does not contain 1 URI type SAN, detected %d", len(peerCert.URIs)) + } + spiffe := peerCert.URIs[0].String() + _, err := resources.ParseIdentity(spiffe) + if err != nil { + return err + } + secretCache := x.pilotAgent.GetWorkloadCertificateProvider() + hostInboundListener := x.pilotAgent.GetHostInboundListener() + if hostInboundListener == nil { + return fmt.Errorf("can not get xds inbound listner info") + } + + spiffeMatch := hostInboundListener.TransportSocket.SubjectAltNamesMatch + spiffeValue := hostInboundListener.TransportSocket.SubjectAltNamesValue + ok := x.matchSpiffeUrl(spiffe, spiffeMatch, spiffeValue) + if !ok { + return fmt.Errorf("client spiffe urll %s can not match %s:%s", spiffe, spiffeMatch, spiffeValue) + } + rootCertPool, err := secretCache.GetCACertPool() + if err != nil { + return fmt.Errorf("no cert pool found ") + } + _, err = peerCert.Verify(x509.VerifyOptions{ + Roots: rootCertPool, + Intermediates: intCertPool, + }) + return err +} + +func (x *xdsTLSProvider) GetClientWorkLoadTLSConfig(url *common.URL) (*tls.Config, error) { + + verifyMap := make(map[string]string, 0) + verifyMap["SubjectAltNamesMatch"] = url.GetParam(constant.TLSSubjectAltNamesMatchKey, "") + verifyMap["SubjectAltNamesValue"] = url.GetParam(constant.TLSSubjectAltNamesValueKey, "") + + cfg := &tls.Config{ + GetCertificate: x.GetWorkloadCertificate, + InsecureSkipVerify: true, Review Comment: ## Disabled TLS certificate check InsecureSkipVerify should not be used in production code. [Show more details](https://github.com/apache/dubbo-go/security/code-scanning/23) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
