He-Pin commented on code in PR #14057: URL: https://github.com/apache/dubbo/pull/14057#discussion_r1559131256
########## dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/state/BitList.java: ########## @@ -93,23 +93,23 @@ public BitList(List<E> originList, BitSet rootSet, List<E> tailList) { } // Provided by BitList only - public List<E> getOriginList() { + public synchronized List<E> getOriginList() { Review Comment: Better to use a read and write lock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org