Re: [PR] Fix netty memory leak [dubbo]

[via GitHub]

finefuture commented on code in PR #14127:
URL: https://github.com/apache/dubbo/pull/14127#discussion_r1581838112


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/DefaultHttp11ServerTransportListener.java:
##########
@@ -82,6 +83,15 @@ protected HttpMessageListener buildHttpMessageListener() {
         return new DefaultHttpMessageListener(listeningDecoder);
     }
 
+    @Override
+    protected void doOnData(HttpInputMessage message) {

Review Comment:
   This only applies to http1 and http2, not grpc, because grpc will accumulate 
inputStream.
   
![image](https://github.com/apache/dubbo/assets/18413695/e835b5d5-7045-4caa-a26f-cad0fa3de47d)
   
   ByteBuf is released when an exception occurs in grpc's doOnData process. 
Under normal circumstances, ByteBuf will be released by the close method of 
LengthFieldStreamingDecoder.
   Normal scene:
   
![image](https://github.com/apache/dubbo/assets/18413695/b625a697-fadf-47d2-9f24-acf655fbd008)
   Error scene:
   
![image](https://github.com/apache/dubbo/assets/18413695/51bc2ff0-9819-407b-be54-ee41d116845a)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org