yin1999 opened a new pull request, #275: URL: https://github.com/apache/dubbo-kubernetes/pull/275
## What is the purpose of the change - The `build-ui` command has been removed from makefile, this PR resumes the build logic in GitHub Workflow. - And, as we uses `dubbo-ui` app to run the file server, the Dockerfile used to run file server has been removed (This is easily recoverable, so removing the file now won't have much impact). - Update the husky prepare hook, see: https://typicode.github.io/husky/how-to.html#ci-server-and-docker ## Brief changelog fix(ci): resume the build logic of the front end ## Verifying this change Run the commands provided in `ui-vue3/README.md` to simulate this. ## CheckList - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo-kubernetes/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. - [x] GitHub Actions works fine on your own branch (it should, as only simple changes have been made). - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
