Yan0613 commented on code in PR #285:
URL: https://github.com/apache/dubbo-kubernetes/pull/285#discussion_r1614250489


##########
app/dubbo-cp/cmd/run.go:
##########
@@ -122,10 +121,10 @@ func newRunCmdWithOpts(opts dubbo_cmd.RunCmdOpts) 
*cobra.Command {
                                runLog.Error(err, "unable to set up DP Server")
                                return err
                        }
-                       if err := defaults.Setup(rt); err != nil {
-                               runLog.Error(err, "unable to set up Defaults")
-                               return err
-                       }
+                       //if err := defaults.Setup(rt); err != nil {
+                       //      runLog.Error(err, "unable to set up Defaults")
+                       //      return err
+                       //}

Review Comment:
   Sorry, because in universal mode, the program stops after ten minutes of 
startup, which is caused by the failure of this component in the program to 
start successfully. Therefore, when I tested the functionality, I commented it 
out, but I forgot to restore it when I submitted it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to