oxsean commented on code in PR #14148:
URL: https://github.com/apache/dubbo/pull/14148#discussion_r1627491462
##########
dubbo-plugin/dubbo-rest-jaxrs/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/JaxrsRestToolKit.java:
##########
@@ -43,6 +49,24 @@ public Object convert(Object value, ParameterMeta parameter)
{
}
return typeConverter.convert(value, MultivaluedHashMap.class);
}
+
+ ParamConverter paramConverter =
paramConverterFactory.getParamConverter(
+ parameter.getType(), parameter.getGenericType(),
parameter.getRealAnnotations());
+ if (paramConverter != null) {
+ Class<?> type =
TypeUtils.getSuperGenericType(paramConverter.getClass(), 0);
Review Comment:
I think type checking is unnecessary. Matching types ensure by
paramConverterFactory. For comparing String.class, you can use `==` directly
```
value.getClass() == String.class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
